diff --git a/README.md b/README.md index 689e535..699dbe6 100644 --- a/README.md +++ b/README.md @@ -14,7 +14,7 @@ include .ci/podman.mk Add subtree to your project: ``` -git subtree add --prefix .ci https://git.zero-downtime.net/ZeroDownTime/ci-tools-lib.git master --squash +git subtree add --prefix .ci https://git.zero-downtime.net/ZeroDownTime/ci-tools-lib.git main --squash ``` diff --git a/ecr_public_lifecycle.py b/ecr_public_lifecycle.py index 7397dc4..40bfc59 100755 --- a/ecr_public_lifecycle.py +++ b/ecr_public_lifecycle.py @@ -41,7 +41,8 @@ for image in sorted(images, key=lambda d: d['imagePushedAt'], reverse=True): _delete = True for tag in image["imageTags"]: # Look for at least one tag NOT beign a SemVer dev tag - if "-" not in tag: + # untagged dev builds get tagged as -g + if "-g" not in tag and "dirty" not in tag: _delete = False if _delete: print("Deleting development image {}".format(image["imageTags"])) diff --git a/podman.mk b/podman.mk index ed5aa26..59286e2 100644 --- a/podman.mk +++ b/podman.mk @@ -8,8 +8,8 @@ SHELL := bash .PHONY: all # All targets are accessible for user .DEFAULT: help # Running Make will run the help target -# Parse version from latest git semver tag -GIT_TAG ?= $(shell git describe --tags --match v*.*.* 2>/dev/null || git rev-parse --short HEAD 2>/dev/null) +# Parse version from latest git semver tag, use short commit otherwise +GIT_TAG ?= $(shell git describe --tags --match v*.*.* --dirty 2>/dev/null || git describe --match="" --always --dirty 2>/dev/null) GIT_BRANCH ?= $(shell git rev-parse --abbrev-ref HEAD 2>/dev/null) TAG ::= $(GIT_TAG)